Support some more texture formats #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EriKWDev
force-pushed
the
ErikWDev/texture-formats
branch
from
4063f26 to
c895a16
Compare
kvark
reviewed
Dec 15, 2024
kvark
reviewed
Dec 15, 2024
EriKWDev
force-pushed
the
ErikWDev/texture-formats
branch
from
177746b to
cac73c3
Compare
|
Do you mind if I squash this? Or you want to squash yourself? |
kvark
approved these changes
Dec 16, 2024
|
Do it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #223
Wasn't quite sure with the naming scheme for the formats so if you have a better capitalization or declaration order feel free to change or come with opinion and I'll change
Translated the gles-texture-descriptions from wgpu-hal though I don't know how to describe the BGR10_A2 format so just did RGBA10_A2 there as well and left a todo.
I also noticed that some 16f formats in gles seemed incorrectly labeled 'FLOAT' when they according to wgpu-hal should have been 'HALF_FLOAT'